A Better Way

D

DS

Is There a better way to write this......

For Each ctl In Me.Controls
If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI" Then
ctl.Visible = False
ElseIf ctl.Tag = "MG" Then
ctl.Visible = False
ElseIf ctl.Tag = "IM" Then
ctl.Visible = False
End If
Next ctl

instead of the else if's

This didn't work.

If ctl.Tag = "MS" Then
ctl.Visible = True
Else:
ctl.Visible = False
End If

Neither did this.

If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI","MG","IM" Then
ctl.Visible = False
End If

Thanks
DS
 
A

Arno R

DS said:
Is There a better way to write this......

For Each ctl In Me.Controls
If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI" Then
ctl.Visible = False
ElseIf ctl.Tag = "MG" Then
ctl.Visible = False
ElseIf ctl.Tag = "IM" Then
ctl.Visible = False
End If
Next ctl

instead of the else if's

This didn't work.

If ctl.Tag = "MS" Then
ctl.Visible = True
Else:
ctl.Visible = False
End If

Neither did this.

If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI","MG","IM" Then
ctl.Visible = False
End If

Thanks
DS
Click to expand...

Have you tried?
For Each ctl In Me.Controls
Select Case ctl.Tag
Case "MS"
ctl.Visible = True
Case else
ctl.Visible = False
End Select
Next ctl

Also how did you write down the tag value in the properties?
Only write MS (without quotes), not "MS".

Hth
Arno R
 
D

DS

Arno said:
Have you tried?
For Each ctl In Me.Controls
Select Case ctl.Tag
Case "MS"
ctl.Visible = True
Case else
ctl.Visible = False
End Select
Next ctl

Also how did you write down the tag value in the properties?
Only write MS (without quotes), not "MS".

Hth
Arno R
Click to expand...
No I haven't I'll give it a try!
Thanks
DS
 
J

John Vinson

Is There a better way to write this......

For Each ctl In Me.Controls
If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI" Then
ctl.Visible = False
ElseIf ctl.Tag = "MG" Then
ctl.Visible = False
ElseIf ctl.Tag = "IM" Then
ctl.Visible = False
End If
Next ctl
Click to expand...

You were close: try

If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI" OR ctl.Tag ="MG" OR ctl.Tag "IM" Then
ctl.Visible = False
End If

Alternatively, a Select Case might be useful:

Select Case ctl.Tag
Case "MS"
ctl.Visible = True
Case "MI", "MG", "IM"
ctl.Visible = False
Case Else
' do nothing
End Select

John W. Vinson[MVP]
 
D

DS

John said:
You were close: try

If ctl.Tag = "MS" Then
ctl.Visible = True
ElseIf ctl.Tag = "MI" OR ctl.Tag ="MG" OR ctl.Tag "IM" Then
ctl.Visible = False
End If

Alternatively, a Select Case might be useful:

Select Case ctl.Tag
Case "MS"
ctl.Visible = True
Case "MI", "MG", "IM"
ctl.Visible = False
Case Else
' do nothing
End Select

John W. Vinson[MVP]
Click to expand...
The first one worked well. Meaning it was the least amount of code!
Thanks John.
And Arno
 
R

Rob Oldfield

DS said:
The first one worked well. Meaning it was the least amount of code!
Thanks John.
And Arno
Click to expand...

....even less code....

for each ctl in me.controls
ctl.visible=(ctl.tag="MS")
next
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Object loop help 7
toggling visibility of labels through code 5
Method or Data Object Not Found 4
Putting 2 Codes Together 4
Data Member or Object not found 3
Managing Visible Property of Label Control 3
using ctl.tag to set to default value 6
Hide Controls on Subform 2

Top