Claus code works on my data not on OP's data

H

Howard

Claus revamped some code of mine to find strings in data field and list the strings, headers of the columns the strings are in and the cell address of the string in three columns.

Tested on a small data set, worked just fine, I expanded the data set to the size of the OP's by using made up data and it too works just fine. (A bit slow but has to do with the For Each in... method looping is my guess)

I run it on OP's "real data" and the code crashes.

If you care to take a look, here is a link to my workbook with two sheets, OP Data and My Test.

Works on My Test, crashes on OP Data.

https://www.dropbox.com/s/l9iszq045...ros Royal Bank String in Array Drop Box.xlsm

Regards,
Howard
 
C

Claus Busch

Hi Howard,

Am Wed, 14 Aug 2013 10:05:15 -0700 (PDT) schrieb Howard:
If you care to take a look, here is a link to my workbook with two sheets, OP Data and My Test.

Works on My Test, crashes on OP Data.

you have to define the range in column A correctly. It takes time to
search for not existing Xs.
Your data works in 23 sec, the OP's data in 9 sec.
Have a look:
https://skydrive.live.com/#cid=9378AAB6121822A3&id=9378AAB6121822A3!326
for the workbook "Royal Bank String"


Regards
Claus B.
 
H

Howard

you have to define the range in column A correctly. It takes time to

search for not existing Xs.

Your data works in 23 sec, the OP's data in 9 sec.

Have a look:

https://skydrive.live.com/#cid=9378AAB6121822A3&id=9378AAB6121822A3!326

for the workbook "Royal Bank String"
Regards

Claus B.

Well, that certainly seems to do the trick.

Pretty tedious to check for accuracy with that many returns scattered all about in the data field.

I did study the returns of the much smaller data field and it was accurate, see no reason to doubt the accuracy of this much larger example.

I was clearly off base thinking filling the blanks in column A with an "X" was a benefit. Remove the blanks first makes a ton of sense.

Thanks Claus.

Regards,
Howard
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top