code -message box not messaging

[Wanna Learn]

Hello
The code below worked fine until I decided to add something. (original code
is from the RonDebruin site)

What I wanted to add was if the following cells are blank -
a message box telling person to complete any cell(s) that is highlighted in
yellow
when I run the macro I get error 400 - cells that I want included are in the
macro below.

Sub Mail_ActiveSheet()

'Working in 2000-2007
Dim FileExtStr As String
Dim FileFormatNum As Long
Dim Sourcewb As Workbook
Dim Destwb As Workbook
Dim TempFilePath As String
Dim TempFileName As String
Dim OutApp As Object
Dim OutMail As Object

Set TestRange = Range("C11,E14,F9,F37,H6,M18,R14,S9,S10,S11,T37,AP18,Y18,")
For Each cell In TestRange
If cell.Value = "" Then
'MsgStr = MsgStr & cell.Address & " "
End If
Next

If MsgStr <> "" Then
Msg = MsgBox("All cells highlighted in yellow must be completed")
Exit Sub
End If



With Application
.ScreenUpdating = False
.EnableEvents = False
End With

Set Sourcewb = ActiveWorkbook

'Copy the sheet to a new workbook
ActiveSheet.Copy
Set Destwb = ActiveWorkbook

'Determine the Excel version and file extension/format
With Destwb
If Val(Application.Version) < 12 Then
'You use Excel 2000-2003
FileExtStr = ".xls": FileFormatNum = -4143
Else
'You use Excel 2007
'We exit the sub when your answer is NO in the security dialog
that you only
'see when you copy a sheet from a xlsm file with macro's
disabled.
If Sourcewb.Name = .Name Then
With Application
.ScreenUpdating = True
.EnableEvents = True
End With
MsgBox "Your answer is NO in the security dialog"
Exit Sub
Else
Select Case Sourcewb.FileFormat
Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
Case 52:
If .HasVBProject Then
FileExtStr = ".xlsm": FileFormatNum = 52
Else
FileExtStr = ".xlsx": FileFormatNum = 51
End If
Case 56: FileExtStr = ".xls": FileFormatNum = 56
Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
End Select
End If
End If
End With

' 'Change all cells in the worksheet to values if you want
' With Destwb.Sheets(1).UsedRange
' .Cells.Copy
' .Cells.PasteSpecial xlPasteValues
' .Cells(1).Select
' End With
' Application.CutCopyMode = False

'Save the new workbook/Mail it/Delete it
TempFilePath = Environ$("temp") & "\"
TempFileName = "Part of " & Sourcewb.Name & " " & Format(Now, "dd-mmm-yy
h-mm-ss")

Set OutApp = CreateObject("Outlook.Application")
OutApp.Session.Logon
Set OutMail = OutApp.CreateItem(0)

With Destwb
.SaveAs TempFilePath & TempFileName & FileExtStr,
FileFormat:=FileFormatNum
On Error Resume Next
With OutMail
.TO = "501591376"
'.Recipients.Add "Internal CS Requests(GE Healthcare)"
.CC = ""
.BCC = ""
.Subject = "Credit-Rebill " & "SSO #" & Range("R14").Value & "
Invoice # " & Range("S10 ").Value & " " & Range("AX35").Value & " Company
" & Range("AC11 ").Value

.Body = ""
.Attachments.Add Destwb.FullName
'You can add other files also like this
'.Attachments.Add ("C:\test.txt")
.Display '.Send 'or use .Display
End With
On Error GoTo 0
.Close SaveChanges:=False
End With

'Delete the file you have send
Kill TempFilePath & TempFileName & FileExtStr

Set OutMail = Nothing
Set OutApp = Nothing

With Application
.ScreenUpdating = True
.EnableEvents = True
End With
End Sub

 

[Dave Peterson]

You haven't declared all your variables.

But this line:

Set TestRange = Range("C11,E14,F9,F37,H6,M18,R14,S9,S10,S11,T37,AP18,Y18,")

Isn't a valid range. You have a comma right before the final double quote.

Then add this to the declaration portion:

Dim TestRange As Range
Dim Cell As Range
Dim MsgStr As String
Dim Msg As Long

If you don't declare MsgStr as a string, then it will be implicitly made a
Variant (some variable that can hold any type of data).

And if msgstr isn't reassigned to anything, then msgstr will be an empty
Variant--different than a 0 length string.