Dialog Box and Save As Location

M

Monk

I am using the code below to display a Save as Dialog Box with the preferred
directory location. The dialog box and correct directory location appear
however the file does not save to that filename / location once the user
presses the Save button.

Any suggestions as to my error would be appreciated

'Retrieve file name to use for Save
Dim WB As Workbook
Dim SH As Worksheet
Dim Rng2 As Range
Dim Rng3 As Range
Dim aStr As String
Dim sPath As String
Dim FName As String

Set WB = ThisWorkbook
Set SH = WB.Sheets("Cash Summ")
Set Rng2 = SH.Range("A1")
Set Rng3 = SH.Range("A2")

If Not IsEmpty(Rng2.Value) Then
aStr = Rng2.Value
aStr2 = Rng3.Value
FName = aStr & aStr2
fileSaveName = Application.GetSaveAsFilename(FName)
End If
End Sub
 
N

Norman Jones

Hi Monk,

The method GetSaveAsFilename returns
the user's selection; it does not save the file.

Therefore, try something like:

'=========>>
Public Sub Tester2()
'Retrieve file name to use for Save
Dim WB As Workbook
Dim SH As Worksheet
Dim Rng2 As Range
Dim Rng3 As Range
Dim aStr As String
Dim sPath As String
Dim FName As String
Dim fileSaveName As Variant

Set WB = ThisWorkbook
Set SH = WB.Sheets("Cash Summ")
Set Rng2 = SH.Range("A1")
Set Rng3 = SH.Range("A2")

If Not IsEmpty(Rng2.Value) Then
aStr = Rng2.Value
aStr2 = Rng3.Value
FName = aStr & aStr2
fileSaveName = Application.GetSaveAsFilename() '(FName)
End If

If Not FName = False Then
WB.SaveAs Filename:=fileSaveName, _
FileFormat:=xlWorkbookNormal
End If
End If
End Sub
'<<=========
 
M

Monk

Thanks for your assistance Norman

I am now getting a RunTime Error 13 (Type Mismatch) warning with the
following line highlighted

If Not FName = False Then
 
N

Norman Jones

Hi Monk,

Apologies! My fault!

Replace
If Not FName = False Then
WB.SaveAs Filename:=fileSaveName, _
FileFormat:=xlWorkbookNormal
End If

with:

If fileSaveName <> False Then
WB.SaveAs Filename:=fileSaveName, _
FileFormat:=xlWorkbookNormal
End If
 
M

Monk

Hi Norman

No apologies necessary. You have assisted me greatly this weekend. Works
perfectly. Thanks
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top