Looking For Advice!!

[NEWER USER]

Which is the CORRECT way to write Code?

Dim strDoc as String
strDoc = "qryTEST
DoCmd.OpenQuery strDoc, acNormal, acEdit

OR

DoCmd.OpenQuery "qryTEST", acNormal, acEdit

Does one run faster than the other? Are both ways acceptable or could
problems arise down the road? If several queries are run back to back,
should I define (Dim) or use the second method above. Any thought
appreciated.

 

[Stuart McCall]

Which is the CORRECT way to write Code?

Dim strDoc as String
strDoc = "qryTEST
DoCmd.OpenQuery strDoc, acNormal, acEdit

OR

DoCmd.OpenQuery "qryTEST", acNormal, acEdit

Does one run faster than the other? Are both ways acceptable or could
problems arise down the road? If several queries are run back to back,
should I define (Dim) or use the second method above. Any thought
appreciated.

The (admittedly awkward) answer is that they're both correct. A general rule
of thumb is if you expect to use the same string of characters more than
once, then your 1st method is the most efficient. If the string is used just
the once, you might as well specify it as a string literal (your 2nd
method).

As far as performance goes, I doubt you could measure the difference between
the two methods, it would be so miniscule.

 

[Dirk Goldgar]

Which is the CORRECT way to write Code?

Dim strDoc as String
strDoc = "qryTEST
DoCmd.OpenQuery strDoc, acNormal, acEdit

OR

DoCmd.OpenQuery "qryTEST", acNormal, acEdit

Does one run faster than the other? Are both ways acceptable or could
problems arise down the road? If several queries are run back to back,
should I define (Dim) or use the second method above. Any thought
appreciated.

There's no significant difference between them. Technically, the second one
is *marginally* more efficient, and that's what I would do if I didn't
anticipate adding any code to choose a different query to be opened. But
the difference in efficiency will never be perceptible to *anyone*, unless
you were running the code an enormous number of times in a tight loop --
which, in the case of this particular code, doesn't make any sense.

If I had a choice of queries to be opened, then I might use a variable to
hold my choice, as in this example:

Dim strQueryName As String

Select Case Me!QueryOption
Case 1 : strQueryName = "qryA"
Case 2 : strQueryName = "qryB"
Case 3 : strQueryName = "qryC"
Case Else: strQueryName = "qryD"
End Select

DoCmd.OpenQuery strQueryName

But for a simple case where I just want to open a foreknown query, I
wouldn't bother using a variable for the query name.

 

[Tony Toews [MVP]]

Which is the CORRECT way to write Code?

Dim strDoc as String
strDoc = "qryTEST
DoCmd.OpenQuery strDoc, acNormal, acEdit

OR

DoCmd.OpenQuery "qryTEST", acNormal, acEdit

Go for the second one. Stuart and Dirk have mentioned some factors.
But, all other factors being negligible, I look at this from next
years viewpoint. The second case will take you a slightly smaller
time to figure out a year from now. Especially if it's part of a
larger module and you have stDoc set lines and lines above the docmd
statement.

Tony
--
Tony Toews, Microsoft Access MVP
Please respond only in the newsgroups so that others can
read the entire thread of messages.
Microsoft Access Links, Hints, Tips & Accounting Systems at
http://www.granite.ab.ca/accsmstr.htm
Tony's Microsoft Access Blog - http://msmvps.com/blogs/access/