on error help

[Matthew Dyer]

Still can't figure this out... assume that all variables are properly
declared. When I comment ( ' ) out the on-error part, the code
operates properly, and if there is an error it will highlight the
MkDir foldername part. But when I make the on error codes active
again, it will execute msgbox and exit sub parts whether or not an
error occurs... What am I doing wrong?

SaveFile = Workbooks("worklist_detail_format_custom.xls").Sheets
("sheet1").Range("D20")
MyPath = SaveFile


'Add a slash at the end if the user forget it
If Right(MyPath, 1) <> "\" Then
MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error Resume Next
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not
Exist" _
& vbNewLine & "Or A File With Today's Date Already Exists In the
Directory", vbOKOnly
Exit Sub
On Error GoTo 0

MkDir foldername

 

[Per Jessen]

Hi

The error will not occure before the MkDir statement, so the error
handling part sould come later.

Look at this:
sub aaa
SaveFile = Workbooks("worklist_detail_format_custom.xls").Sheets
("sheet1").Range("D20")
MyPath = SaveFile

'Add a slash at the end if the user forget it
If Right(MyPath, 1) <> "\" Then
MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error GoTo ErrHandler
MkDir foldername
Exit Sub

ErrHandler:
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not "
Exist "" _
& vbNewLine & "Or A File With Today's Date Already Exists In the "
Directory ", vbOKOnly "
End Sub

Regards,
Per

 

[Matthew Dyer]

Hi

The error will not occure before the MkDir statement, so the error
handling part sould come later.

Look at this:
sub aaa
SaveFile = Workbooks("worklist_detail_format_custom.xls").Sheets
("sheet1").Range("D20")
MyPath = SaveFile

'Add a slash at the end if the user forget it
If Right(MyPath, 1) <> "\" Then
    MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error GoTo ErrHandler
MkDir foldername
Exit Sub

ErrHandler:
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not "
Exist "" _
& vbNewLine & "Or A File With Today's Date Already Exists In the "
Directory ", vbOKOnly "
End Sub

Regards,
Per








- Show quoted text -

I tried the GoTo <label>: but that isn't working for me either. It is
displaying the msgbox if there's an error or not...

 

[Per Jessen]

If you have an Exit Sub just before the ErrHandler: label, you will
only get the message if there is an error.

After the 'error message' try to insert the line below and see the
error in the Immediate window:

Debug.Print Err.Number & " " & Err.Description

Hopes this helps.
....
Per

 

[norie]

Why use On Error in the first place?

Couldn't you just check for the existence of the directory using the
Dir function with the 2nd argument set to vbDirectory?