Open Recordset in Loop

[ajbarilla]

I am having problems opening a recordset within a loop. Below is my
code and I get a compile error (End if without block if) when I try to
run it. The loop and recordset code work independently but not
togother. The code is to merge several documents based on ones that
are selected in a list box. the code below contains just the begining
of the merge not the entire merging process.


For intCurrentRow = 0 To ctlSource.ListCount - 1
If ctlSource.Selected(intCurrentRow) Then
SearchCrit = List0.ItemData(intCurrentRow)
Set rst = db.openrecordset("SELECT * FROM tblDocumentList WHERE
tbldocumentlist.[Document] = '" & SearchCrit & "'")
With rst
docpath = !location
rst.Close
End If

Next intCurrentRow

 

[Daniel]

Code formatting would help you identify the source of your problem.

For intCurrentRow = 0 To ctlSource.ListCount - 1
If ctlSource.Selected(intCurrentRow) Then
SearchCrit = List0.ItemData(intCurrentRow)
Set rst = db.openrecordset("SELECT * FROM tblDocumentList WHERE
tbldocumentlist.[Document] = '" & SearchCrit & "'")
With rst
docpath = !location
End With 'This was missing
rst.Close
End If
Next intCurrentRow 'This was missing

Daniel

 

[Douglas J. Steele]

You're missing the End With to close the With rst line.

Realistically, there's no advantage to using With: I'd remove the

With rst

line, and change

docpath = !location

to

docpath = rst!location

 

[aaron.kempf]

dude don't fucking use DAO for anything

no wonder your shit hangs up on you

 

[ES]

looks like you are missing the "End With"

 

[aaron.kempf]

good stuff

for the record, you fucking retard

DAO hasn't been included with 70% of the recent Office releases.. and
it hasn't been present on Windows since Windows 2000, right?

-Aaron