Question on a Chip Pearson macro

H

Hash

All -

It is with no little temerity that I post this question about a Chip
Pearson macro found at:

http://www.cpearson.com/excel/deleting.htm

The subject is deleting duplicate rows. The code is below and I don't
understand variables Col, C, and N.

Col appears assigned and never used. N appears assigned and
incremented, but never used. And C appears to be neither. My sense is
that it should be

V = Rng.Cells(r, Col).value

and

....CountIf(Col, V) > 1 Then

But I don't know, and I don't understand, particularly N and C. N is
the number of deletions, but nothing seems to use N.

Deleting Duplicate Rows is something I want to do.

Thanks in advance, and awaiting enlightenment.
....best, Hash


Public Sub DeleteDuplicateRows()
'
' This macro deletes duplicate rows in the selection. Duplicates are
' counted in the COLUMN of the active cell.

Dim Col As Integer
Dim r As Long
Dim C As Range
Dim N As Long
Dim V As Variant
Dim Rng As Range

On Error GoTo EndMacro
Application.ScreenUpdating = False
Application.Calculation = xlCalculationManual

Col = ActiveCell.Column

If Selection.Rows.Count > 1 Then
Set Rng = Selection
Else
Set Rng = ActiveSheet.UsedRange.Rows
End If

N = 0
For r = Rng.Rows.Count To 1 Step -1
V = Rng.Cells(r, 1).Value
If Application.WorksheetFunction.CountIf(Rng.Columns(1), V) > 1 Then
Rng.Rows(r).EntireRow.Delete
N = N + 1
End If
Next r

EndMacro:

Application.ScreenUpdating = True
Application.Calculation = xlCalculationAutomatic

End Sub
 
M

Martin Fishlock

Hash:

It appears that these are not needed.

As always this is one of the things that VBA is lacking - code analysis,
that is unless someone else knows otherwise.
 
C

Chip Pearson

Those variables are left-overs from a more complicated macro from
which this one was adapted. They are not needed.


--
Cordially,
Chip Pearson
Microsoft MVP - Excel
Pearson Software Consulting, LLC
www.cpearson.com
 
H

Hash

Chip -

Thank you, and thank you for showing the way. I was about to start a
sorting macro that put duplicates together and de-dupe from there.

No surprise, but your way is better.

....best, Hash
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top