Why does this not work

C

Corey

I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2 Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?


Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText, LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub


Corey....
 
D

Dave Peterson

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)


..cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
 
C

Corey

Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub


If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....


Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)


..cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
 
D

Dave Peterson

I didn't notice the "with textbox2.value" in the original post.

Maybe this version:


'declare BlkProc at the top of the module--not in any sub.
Dim BlkProc as boolean

Private Sub TextBox2_Change()

Dim rngFound As Range

if blkproc = true then exit sub

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
end with

if rngFound is nothing then
msgbox "none found"
else
MsgBox "That Item " & TextBox1.Value & _
" is ALREADY in the List of Items to be Done", vbInformation
End If

blkProc = true
TextBox2.Value = UCase(TextBox2.Value)
blkproc = false

End Sub
Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

.cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2
Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?

Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText, LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

Corey....
Click to expand...
Click to expand...
 
C

Corey

Seem to get a Sub Script Out of Range error here :

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

???



I didn't notice the "with textbox2.value" in the original post.

Maybe this version:


'declare BlkProc at the top of the module--not in any sub.
Dim BlkProc as boolean

Private Sub TextBox2_Change()

Dim rngFound As Range

if blkproc = true then exit sub

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
end with

if rngFound is nothing then
msgbox "none found"
else
MsgBox "That Item " & TextBox1.Value & _
" is ALREADY in the List of Items to be Done", vbInformation
End If

blkProc = true
TextBox2.Value = UCase(TextBox2.Value)
blkproc = false

End Sub
Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

.cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2
Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?

Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText,
LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

Corey....
Click to expand...
Click to expand...
 
D

Dave Peterson

I shouldn't have trusted your original code <vbg>.

LookIn:=xlValues
not
LookIn:=xlText
Seem to get a Sub Script Out of Range error here :

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

???

I didn't notice the "with textbox2.value" in the original post.

Maybe this version:

'declare BlkProc at the top of the module--not in any sub.
Dim BlkProc as boolean

Private Sub TextBox2_Change()

Dim rngFound As Range

if blkproc = true then exit sub

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
end with

if rngFound is nothing then
msgbox "none found"
else
MsgBox "That Item " & TextBox1.Value & _
" is ALREADY in the List of Items to be Done", vbInformation
End If

blkProc = true
TextBox2.Value = UCase(TextBox2.Value)
blkproc = false

End Sub
Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

.cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2
Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?

Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText,
LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

Corey....
Click to expand...
Click to expand...
Click to expand...
 
C

Corey

Thank you Dave,
You know i actual changed that but to, Lookin:=xlValue minus the 's'

Cheers
Appreciate you asisstance

Corey....

I shouldn't have trusted your original code <vbg>.

LookIn:=xlValues
not
LookIn:=xlText
Seem to get a Sub Script Out of Range error here :

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

???

I didn't notice the "with textbox2.value" in the original post.

Maybe this version:

'declare BlkProc at the top of the module--not in any sub.
Dim BlkProc as boolean

Private Sub TextBox2_Change()

Dim rngFound As Range

if blkproc = true then exit sub

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
end with

if rngFound is nothing then
msgbox "none found"
else
MsgBox "That Item " & TextBox1.Value & _
" is ALREADY in the List of Items to be Done", vbInformation
End If

blkProc = true
TextBox2.Value = UCase(TextBox2.Value)
blkproc = false

End Sub
Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

.cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.
I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2
Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?

Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText,
LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

Corey....
Click to expand...
Click to expand...
Click to expand...
 
D

Dave Peterson

Sometimes VBA's help is very "helpful".

Or just recording a macro so you can see how things are spelled.
Thank you Dave,
You know i actual changed that but to, Lookin:=xlValue minus the 's'

Cheers
Appreciate you asisstance

Corey....

I shouldn't have trusted your original code <vbg>.

LookIn:=xlValues
not
LookIn:=xlText
Seem to get a Sub Script Out of Range error here :

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

???

I didn't notice the "with textbox2.value" in the original post.

Maybe this version:

'declare BlkProc at the top of the module--not in any sub.
Dim BlkProc as boolean

Private Sub TextBox2_Change()

Dim rngFound As Range

if blkproc = true then exit sub

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
end with

if rngFound is nothing then
msgbox "none found"
else
MsgBox "That Item " & TextBox1.Value & _
" is ALREADY in the List of Items to be Done", vbInformation
End If

blkProc = true
TextBox2.Value = UCase(TextBox2.Value)
blkproc = false

End Sub
Dave,
after you advice i have:

Private Sub TextBox2_Change()
With TextBox2.Value
'Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Cells(.Cells.Count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
MsgBox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

If i remove the ['] on the On Error Resume Next i Get an error in the SET rngFound section,
But if i leave th e['] in on the O E R N line, it get nothing occurring.
Did i understand correctly ?

Corey....

Without testing at all...

Since you're using a with/end with statement here:
With Worksheets("Sheet2").Range("C:C")
Then this portion: after:=.range("c1") refers to something not in column C.

Try this in the immediate window:
msgbox range("c:c").range("c1").address

I'd use:
after:=.cells(1)
(the first cell in the range specified in the With statement.)

Actually, I'd use:

With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.cells(.cells.count), _
LookIn:=xlText, LookAt:=xlWhole, SearchOrder:=xlByRows, _
SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)

.cells(.cells.count) will mean that you're looking after the last cell in column
C (C65536 in xl2003).

This would make a difference if C1 could be the cell that contains the value for
which you're looking.

Corey wrote:

I am trying to set this code to pick up IF the exact Text(sentance) match is found in Sheet2
Column
C,
is used in Textbox2 then i get a Prompt to Say so, else a Prompt to say NOT.

But why does it not work, although a MATCH is there ?

Private Sub TextBox2_Change()
With TextBox2.Value
Dim rngFound As Range
On Error Resume Next
With Worksheets("Sheet2").Range("C:C")
Set rngFound = .Find(What:=TextBox2.Text, After:=.Range("C1"), LookIn:=xlText,
LookAt:=xlWhole,
SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, Matchbyte:=False)
If rngFound.Count <> "" Then
MsgBox "That Item " & TextBox1.Value & " is ALREADY in the List of Items to be Done",
vbInformation
Else
Msgbox "None Found"
Exit Sub
End If
End With
End With
TextBox2.Value = UCase(TextBox2.Value)
End Sub

Corey....
Click to expand...
Click to expand...
Click to expand...
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Word macro that can call cells out of Excel for a find and replace 0
Search always ends in a find, but should not 3
2 If/Then statements in 1 sub not working correctly 3
Match style 0
Code does not error but no copy either 4
Why does the list get bigger ? 3
Populating a userform from data in a sheet problem. Is it an Obvious error ?? 1
Placing the MsgBox "No ID found" statement in my code?? 12

Top